Review Request 124696: Fix (worrying) MSVC warning

Milian Wolff mail at milianw.de
Tue Aug 11 11:21:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124696/#review83699
-----------------------------------------------------------

Ship it!



src/iddecorator.cpp (line 36)
<https://git.reviewboard.kde.org/r/124696/#comment57929>

    while at it: make static or wrap in anonymous namespace (in a separate commit?)


- Milian Wolff


On Aug. 11, 2015, 11 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124696/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 11 a.m.)
> 
> 
> Review request for KDE Frameworks and Mirko Boehm.
> 
> 
> Repository: threadweaver
> 
> 
> Description
> -------
> 
> Warning:
> Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning
> C4312: 'r
> einterpret_cast': conversion from 'const int' to
> 'ThreadWeaver::IdDecorator::Pri
> vate2 *' of greater size
> 
> 
> Diffs
> -----
> 
>   src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/124696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150811/38a45a0c/attachment.html>


More information about the Kde-frameworks-devel mailing list