Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124684/#review83685
-----------------------------------------------------------

Ship it!


I'm not the reviewer for kdelibs4support but I have used Taglib; the change looks good to me.

- Michael Pyne


On Aug. 10, 2015, 9:56 a.m., Luca Sartorelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124684/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 9:56 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Wrong string comparison of taglib version
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindTaglib.cmake 5bbb8ee 
> 
> Diff: https://git.reviewboard.kde.org/r/124684/diff/
> 
> 
> Testing
> -------
> 
> Run cmake with kdesrc-build on debian strecth
> taglib version correctly found and parsed
> 
> 
> Thanks,
> 
> Luca Sartorelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150810/8ef75c50/attachment.html>