Review Request 124208: Fallback for componentFriendlyForAction name resolving

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124208/#review83642
-----------------------------------------------------------


It looks that this patch doesn't work as it should. For me action->property("componentDisplayName") always returns an empty string and thus "System setting" is used from QGuiApplication::applicationDisplayName() for all components. When I open configuration for global shortcuts for the first time I see like ~10 components, but after it gets saved then everything is merged into one component called "System settings". This was working fine before this change.

- Jan Grulich


On Čec. 1, 2015, 7:49 dop., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124208/
> -----------------------------------------------------------
> 
> (Updated Čec. 1, 2015, 7:49 dop.)
> 
> 
> Review request for KDE Frameworks and Harald Sitter.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> Currently the name is resolved from an undocumented dynamic property
> which gets set by KActionCollection (xmlgui). If one uses KGlobalAccel
> without using KActionCollection one would have to know the name of
> the private property.
> 
> To provide a better name the method performs the same fallbacks as
> KActionCollection. If the property is not set, it uses either the
> application display name or the application name.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.cpp 6838bbcfd91d690c067b12db133b6abca5f24203 
> 
> Diff: https://git.reviewboard.kde.org/r/124208/diff/
> 
> 
> Testing
> -------
> 
> KWin's component now reported properly as "KWin". (KWin is the testcase as it doesn't use xmlgui.)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150810/5c40f068/attachment.html>