Review Request 124542: CMake fixes for Windows build

[Dāvis Mosāns]

> On Aug. 8, 2015, 5:40 p.m., Kevin Funk wrote:
> > @Luigi: Bump?
> 
> Luigi Toscano wrote:
>     I was waiting for D?vis' answer, but given that 5.13 is out, there is enough time to fix it before 5.14. So let's go, and thanks.
> 
> Luigi Toscano wrote:
>     Just please remember to use a more descriptive commit message than just the bug number :)

Why would you wait for me..., I was just commenting and I don't have any objections as otherwise I would have said something. Of course proper fix would be preferable to any workarounds (I generally really dislike hacks :P) but workaround today is better than nothing (broken app) for ages.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124542/#review83574
-----------------------------------------------------------


On Aug. 6, 2015, 9:37 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124542/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 9:37 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 348061
>     https://bugs.kde.org/show_bug.cgi?id=348061
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> BUG: 348061
> 
> 
> Diffs
> -----
> 
>   cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 
> 
> Diff: https://git.reviewboard.kde.org/r/124542/diff/
> 
> 
> Testing
> -------
> 
> Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas.
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150808/d8cb3778/attachment-0001.html>