Review Request 124646: Let the RowLayout figure out the size of the label

David Edmundson david at davidedmundson.co.uk
Fri Aug 7 00:41:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124646/#review83526
-----------------------------------------------------------

Ship it!


Ran the buttons.qml test file, all seems fine.

- David Edmundson


On Aug. 6, 2015, 2:48 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124646/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It just works and doesn't let us make weird assumptions.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml 152d01f 
> 
> Diff: https://git.reviewboard.kde.org/r/124646/diff/
> 
> 
> Testing
> -------
> 
> Works with the Breeze lock screen and Muon Discover's MessageAction.qml.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150807/24d103ed/attachment.html>


More information about the Kde-frameworks-devel mailing list