Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124607/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 9:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Vishesh Handa.


Changes
-------

Submitted with commit ddd57bccdff99eea813b1ccee4d7071dd3978cd7 by David Faure to branch master.


Repository: kservice


Description
-------

This fixes threads without an event loop (e.g. in krunner) never noticing
changes in ksycoca.

Done-with: Vishesh Handa


Diffs
-----

  autotests/ksycocathreadtest.cpp 0d6ed4b89581fc506ea79c32c1de314637decf3e 
  src/services/kmimetypetrader.cpp 655e5de9d272176e06af48a8417ea06e2412b9d8 
  src/services/kplugininfo.cpp 56dc0b43036a2a49804ff799360c29c2121dda54 
  src/services/kservice.cpp 3639a2875e5dbaefc6511d36d7b7f0fb7697ea74 
  src/services/kservicegroup.cpp a2905da347877ccf34677776b63bd0eae518101f 
  src/services/kservicetype.cpp 5e71351e5b7a0acef96104d8d14fa5b27817595d 
  src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af 
  src/sycoca/ksycoca.h 542029c7c21d495456065e51b485a26509152cd5 
  src/sycoca/ksycoca.cpp 32d1689ad9cd01d3a8adb5123a1848278714ca95 
  src/sycoca/ksycoca_p.h 393cfcf8f04c369ac9c03712d917c49112771838 

Diff: https://git.reviewboard.kde.org/r/124607/diff/


Testing
-------

The improved unittest was failing with threadsWhoSawFakeService() always only 2 out of 5 (the 2 threads with an event loop). Passes now.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150805/e28f5644/attachment-0001.html>