Review Request 122987: Allow user to specify path to myspell dictionary files

Rex Dieter rdieter at gmail.com
Wed Aug 5 13:22:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review83458
-----------------------------------------------------------

Ship it!


This is the obvious easy fix (I was about to submit when I noticed this already-open reviewboard submission).  Given the polish and feedback already (and lack of any notable objections), let's get it committed asap.

- Rex Dieter


On April 27, 2015, 1:30 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 1:30 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt e35fe8c 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 46963ef 
>   src/plugins/hunspell/hunspelldict.cpp fda4a4c 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150805/e86cf591/attachment.html>


More information about the Kde-frameworks-devel mailing list