Review Request 124623: Allow multiple entries in the maintainers field

David Faure faure at kde.org
Tue Aug 4 23:07:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124623/#review83445
-----------------------------------------------------------

Ship it!


Thanks for the fix!

- David Faure


On Aug. 4, 2015, 10:24 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124623/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 10:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Allow multiple entries in the maintainers field
> 
> 
> Diffs
> -----
> 
>   src/kapidox/data/templates/fwinfo.html 647baec06aa0d5df20ff6afdc9313dceabe15e02 
>   src/kapidox/data/templates/fwmaintainer.html fb1c5677ecf24874da8eaee283c75cc44841c417 
>   src/kgenframeworksapidox 4b2d36f01e0299f41b94a96e80bce54de7f8ef58 
> 
> Diff: https://git.reviewboard.kde.org/r/124623/diff/
> 
> 
> Testing
> -------
> 
> Ran with just three frameworks, one set to have multiple maintainers, one set to have no (valid) maintainers and one set to have a single maintainer. All produced the expected output, both on the main listing (with the show maintainers option selected) and on the individual apidocs home pages.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150804/ec3f70ec/attachment.html>


More information about the Kde-frameworks-devel mailing list