Review Request 124542: CMake fixes for Windows build

Luigi Toscano luigi.toscano at tiscali.it
Sun Aug 2 21:50:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124542/#review83349
-----------------------------------------------------------


Kevin, when you update the patch, and after the ship it (which will come, I'm sure), please update the description with the real commit message which will end up in the git repository (just BUG: xyzt and REVIEW: tzyz is not enough).

- Luigi Toscano


On Ago. 1, 2015, 11:40 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124542/
> -----------------------------------------------------------
> 
> (Updated Ago. 1, 2015, 11:40 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 348061
>     https://bugs.kde.org/show_bug.cgi?id=348061
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> BUG: 348061
> 
> 
> Diffs
> -----
> 
>   cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 
> 
> Diff: https://git.reviewboard.kde.org/r/124542/diff/
> 
> 
> Testing
> -------
> 
> Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas.
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150802/9e3d158d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list