Review Request 124596: KBookmarkManager: revert the port from KDirWatch to QFileSystemWatcher.
David Faure
faure at kde.org
Sun Aug 2 18:36:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124596/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kbookmarks
Description
-------
QFileSystemWatcher is not able to watch a file that doesn't exist yet,
it just says
QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No such file or directory
and that's the end of it.
We ported to QFileSystemWatcher to reduce deps, but in the end we kept
KDirWatch, in KCoreAddons.
Diffs
-----
src/kbookmarkmanager.cpp ad6af1ca0c87fe41fd4800ebf5d2924d3bd186fd
autotests/kbookmarktest.cpp 9a32c2a9e4e1c21ef5c6475f31ed1a67e0e627b4
autotests/kbookmarktest.h 2127ce89dde030beed2b680af9a0bc452962f4c8
Diff: https://git.reviewboard.kde.org/r/124596/diff/
Testing
-------
unittest added
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150802/cf849d79/attachment.html>
More information about the Kde-frameworks-devel
mailing list