kemoticons unittests broken

David Faure faure at kde.org
Sat Aug 1 19:32:39 UTC 2015


On Saturday 01 August 2015 21:04:38 kainz.a wrote:
> Hi,
> 
> I have no glue how I can fix it, could you please look into the problem.

It's not that hard, you ensure the test is compiled
(pass -DBUILD_TESTING=TRUE to cmake)
then you run the test
(cd autotest ; ./kemoticons-kemoticontest)
then you look into the errors and fix them ;)

FAIL!  : KEmoticonTest::testEmoticonParser(working-1) Compared values are not the same
   Actual   (result)      : "<img align=\"center\" title=\":)\" alt=\":)\" src=\"face-smile.png\" width=\"22\" height=\"22\" /><img align=\"center\" title=\":)\" alt=\":)\" src=\"face-smile.png\" width=\"22\" height=\"22\" />"
   Expected (expectedData): "<img align=\"center\" title=\":)\" alt=\":)\" src=\"smile.png\" width=\"22\" height=\"22\" /><img align=\"center\" title=\":)\" alt=\":)\" src=\"smile.png\" width=\"22\" height=\"22\" />"

I assume this is simply because breeze was using smile.png while the new theme uses face-smile.png?
So this is likely just a case of updating the expected values in git.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list