Review Request 124578: Fix deprecated KRun::run call
David Faure
faure at kde.org
Sat Aug 1 11:33:19 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124578/#review83288
-----------------------------------------------------------
Ship it!
Yep, looks good.
src/qmlcontrols/kioplugin/krunproxy.cpp (line 43)
<https://git.reviewboard.kde.org/r/124578/#comment57536>
(what a strange typo in "mimetype")
- David Faure
On Aug. 1, 2015, 10:52 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124578/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 10:52 a.m.)
>
>
> Review request for KDE Frameworks and Antonis Tsiapaliokas.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Let's assume we don't want to change the exposed API to users so just use the new call and use != 0 for success.
>
>
> Diffs
> -----
>
> src/qmlcontrols/kioplugin/krunproxy.cpp 914badd
>
> Diff: https://git.reviewboard.kde.org/r/124578/diff/
>
>
> Testing
> -------
>
> Compiles
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150801/cb3fdf07/attachment.html>
More information about the Kde-frameworks-devel
mailing list