Review Request 124552: Update docbooks in kdelibs4support
David Faure
faure at kde.org
Sat Aug 1 08:08:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124552/#review83279
-----------------------------------------------------------
docs/kdebugdialog5/index.docbook (line 38)
<https://git.reviewboard.kde.org/r/124552/#comment57511>
"kDebug has been deprecated and uses Qt's builtin debugging instead" sounds strange (the "uses" verb).
kDebug was always built on top of qDebug, that's not the point.
I would rather say something like:
kDebug has been deprecated in KF5, in favour of Qt's builtin categorized logging [....]
docs/kdebugdialog5/index.docbook (line 127)
<https://git.reviewboard.kde.org/r/124552/#comment57512>
KDEHOME is dead. This should be -> $<envar>XDG_CONFIG_HOME</envar>/kdebugrc
(~/.config/kdebugrc by default)
docs/kf5-config/man-kf5-config.1.docbook (line 53)
<https://git.reviewboard.kde.org/r/124552/#comment57513>
It would be good to mention that kf5-config is mostly a deprecated replacement for kde4-config, while the recommended tool to use instead is qtpaths (which is shipped with Qt).
- David Faure
On July 31, 2015, 2:54 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124552/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 2:54 p.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> Proofread + update to kf5
>
>
> Diffs
> -----
>
> docs/kdebugdialog5/index.docbook 7c49614
> docs/kf5-config/man-kf5-config.1.docbook d4a6e1c
>
> Diff: https://git.reviewboard.kde.org/r/124552/diff/
>
>
> Testing
> -------
>
> builds
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150801/2416b82e/attachment.html>
More information about the Kde-frameworks-devel
mailing list