Review Request 123532: Add find modules for ModemManager and NetworkManager

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123532/
-----------------------------------------------------------

(Updated Dub. 30, 2015, 8:33 dop.)


Review request for KDE Frameworks and Lamarque Souza.


Changes
-------

Use UPPERCASE_NAME_FOO variables for backward compatibility. I couldn't find another approach than using unset() for all variables which are set automatically.


Repository: extra-cmake-modules


Description
-------

This patch adds FindModemManager.cmake and FindNetworkManager.cmake into other find modules. These are required for modemmanager-qt and networkmanager-qt, which are currently missing public dependencies on ModemManager/NetworkManager and to be able to add them, we need to have these find modules publicly available. Note, that my knowledge of CMake is quite limited, so proper review would be needed :).


Diffs (updated)
-----

  find-modules/FindModemManager.cmake PRE-CREATION 
  find-modules/FindNetworkManager.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123532/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150430/505992fd/attachment-0001.html>