Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

[David Faure]

> On April 27, 2015, 3:10 p.m., David Faure wrote:
> > src/widgets/kpropertiesdialog.cpp, line 279
> > <https://git.reviewboard.kde.org/r/123523/diff/1/?file=363715#file363715line279>
> >
> >     Ouch! A nested event loop! Nasty. Opens the door to unexpected reentrancy....
> >     
> >     Not to mention blocking the GUI for a very long time if this is done with many urls over a very slow protocol.
> >     
> >     Better write a multi-stat job if we don't have one, and let the application use that, and open the properties dialog from a slot.
> >     
> >     Alternatively, the properties dialog could itself delay showing itself until it has stat'ed the urls (using a slot, not a blocking nested event loop).
> 
> Emmanuel Pescosta wrote:
>     Copied the code from KPropertiesDialog(url) incl. the warning from showDialog(url), but I agree that this
>     should be fixed. (also for KPropertiesDialog(url))
>     
>     > Better write a multi-stat job if we don't have one
>     
>     Ok I'll have a look at it :)
> 
> Aleix Pol Gonzalez wrote:
>     I agree that would be better, but he copied code that was already in place and is being distributed. :)

Hmm OK. Let's keep propagating old mistakes :-)

Separate issue then, I remove my objection.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123523/#review79577
-----------------------------------------------------------


On April 27, 2015, 11:49 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123523/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 11:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Added KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls) as convenience methods for non-file-manager applications, where you have a list of QUrls rather than a KFileItemList.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.h 8d98b35 
>   src/widgets/kpropertiesdialog.cpp 37fa88f 
> 
> Diff: https://git.reviewboard.kde.org/r/123523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150428/c66e1386/attachment.html>