Review Request 123490: Fix crash when using x11 functionality on platform wayland

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123490/
-----------------------------------------------------------

(Updated April 28, 2015, 6:24 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 9bb99d6c06e014c7fd202597aef90afa2eaa0d38 by Martin Gräßlin to branch master.


Bugs: 346496
    https://bugs.kde.org/show_bug.cgi?id=346496


Repository: kwindowsystem


Description
-------

This already exists for NETRootInfo, so makes the API more compatible.

CHANGELOG: new method NETWinInfo::xcbConnection() -> xcb_connection_t*

Do not hard depend on QX11Info in KXUtils::createPixmapFromHandle

KXUtils::createPixmapFromHandle is used from e.g.
KWindowSystemPrivateX11::icon which can be used on platforms != xcb. So
the methods called from that method should not hard depend on platform
xcb.

BUG: 346496
FIXED-IN: 5.10
CHANGELOG: Don't depend on QX11Info in KXUtils::createPixmapFromHandle


Diffs
-----

  src/netwm.cpp ae88a3b90539de63c8cb8a173ce55a9fc19f6eaf 
  src/netwm.h 76d13e9282829e882fe14a57b4c6413c993c9812 
  src/kxutils_p.h 77485c203eac5dc8e48da1b4f4f5abbbab110120 
  src/kwindowsystem_x11.cpp d2c13b15617e9da2939b4e470c5c0237889921b7 
  src/kxutils.cpp 015749db559c8426da0abfc7764797cf93f8f6b9 

Diff: https://git.reviewboard.kde.org/r/123490/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150428/53e1be73/attachment.html>