Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123523/#review79569
-----------------------------------------------------------

Ship it!



src/widgets/kpropertiesdialog.h (line 130)
<https://git.reviewboard.kde.org/r/123523/#comment54363>

    The argument should be called urls. The _underscore makes it look weird



src/widgets/kpropertiesdialog.h (line 234)
<https://git.reviewboard.kde.org/r/123523/#comment54364>

    Same


Other than that small detail, it makes sense to me.

If we can get a list of file items, we can get a url list.

- Aleix Pol Gonzalez


On April 27, 2015, 1:49 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123523/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 1:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Added KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls) as convenience methods for non-file-manager applications, where you have a list of QUrls rather than a KFileItemList.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.h 8d98b35 
>   src/widgets/kpropertiesdialog.cpp 37fa88f 
> 
> Diff: https://git.reviewboard.kde.org/r/123523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150427/30dc975e/attachment.html>