Review Request 123491: Add a test that checks the modules we're depending on exist

Kevin Funk kfunk at kde.org
Fri Apr 24 15:15:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79452
-----------------------------------------------------------

Ship it!



modules/ECMGeneratePriFile.cmake (line 174)
<https://git.reviewboard.kde.org/r/123491/#comment54298>

    Rather: `${PRI_TARGET_BASENAME}_test.pro`?
    
    (Uses the correct suffix)


- Kevin Funk


On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123491/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 2:53 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do some sanity checking on the dependencies we're declaring
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/123491/diff/
> 
> 
> Testing
> -------
> 
> Ran make test in ktextwidgets without http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 and it correctly failed.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150424/c5c9125e/attachment.html>


More information about the Kde-frameworks-devel mailing list