Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123479/
-----------------------------------------------------------

(Updated April 24, 2015, 12:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause.


Changes
-------

Submitted with commit ff964c0c42202228348213e7d5c10f5611a9ee54 by Milian Wolff to branch master.


Repository: kcoreaddons


Description
-------

The len in inotify_event includes nulls of the name. To prevent
them from being included in the QString/QByteArray we must filter
them manually with a recent Qt 5 dev build now. See also:

https://codereview.qt-project.org/#/c/106473/

REVIEW: 123479


Diffs
-----

  autotests/kdirwatch_unittest.cpp 83b5b410e987fb45a08f8251ec65496c8074b077 
  src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930 

Diff: https://git.reviewboard.kde.org/r/123479/diff/


Testing
-------

I used the test and looked at the output and also ran it against a patched qtbase with this:

https://paste.kde.org/pmoue241d


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150424/1a2e51ec/attachment.html>