Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

[Matthew Dawson]

> On April 23, 2015, 12:55 p.m., Milian Wolff wrote:
> > How are kf5 releases handled btw? Do I need to push this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5).
> 
> Luigi Toscano wrote:
>     The current schedule is one release every month, no patch releases, master always build-able.

KF5 has monthly releases from the master branch, and no patch release unless something critical shows up.  So this should just get pushed to master once the ship it is given.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123479/#review79399
-----------------------------------------------------------


On April 23, 2015, 12:50 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123479/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 12:50 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> The len in inotify_event includes nulls of the name. To prevent
> them from being included in the QString/QByteArray we must filter
> them manually with a recent Qt 5 dev build now. See also:
> 
> https://codereview.qt-project.org/#/c/106473/
> 
> REVIEW: 123479
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930 
> 
> Diff: https://git.reviewboard.kde.org/r/123479/diff/
> 
> 
> Testing
> -------
> 
> I used the test and looked at the output and also ran it against a patched qtbase with this:
> 
> https://paste.kde.org/pmoue241d
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150423/0c23f3cb/attachment.html>