Places bookmark bug - Help needed

[Emmanuel Pescosta]

Hi everyone,

I want to ask you, if you can help me to fix the "Places bookmarks
disappear" bug [1], which was introduced by commit
2b5c6e42fc8114c6854ce490b9cdd4356be683d9 in kdelibs [2].

The adoption for Dolphin [3] has no effect on this bug.

I have done some research and I'm a little bit confused why
KFilePlacesModel has a (not exported) KFilePlacesSharedBookmarks, which
syncs the bookmarks (user-places.xbel and kfileplaces/bookmarks.xml) on
each change. What is the purpose of it? Is it to keep backward
compatibility for bookmarks.xml users?

My assumption is, that before the bookmarks race condition has been fixed,
each places change in Dolphin implicitly triggered a bookmarks sync in the
KFilePlacesModel.
Do we need to sync the bookmarks in Dolphin as well? But why do we store
the bookmarks in two files? Why not only in bookmarks.xml or
user-places.xbel?

So the possible solutions I see are:
* Store the bookmarks in one file (user-places.xbel) and remove the syncing
* Move KFilePlacesSharedBookmarks to KBookmarks and integrate it into the
current code so that all clients of KBookmarks automatically make use of it

Thanks in advance! :)

Cheers,
Emmanuel

[1] https://bugs.kde.org/show_bug.cgi?id=345174
[2]
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=2b5c6e42fc8114c6854ce490b9cdd4356be683d9
[3] https://git.reviewboard.kde.org/r/122640/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150423/68aa28e5/attachment.html>