Review Request 123477: Add public dependency on NetworkManager

[Jan Grulich]

> On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote:
> > KF5NetworkManagerQtConfig.cmake.in, line 4
> > <https://git.reviewboard.kde.org/r/123477/diff/1/?file=362685#file362685line4>
> >
> >     nitpick. weird 1 space indentation.

Already spotted.


On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote:
> > And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers.

I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still cannot find it. I guess this would have to be done according to other FindFoo.cmake modules from extra-cmake-modules, right?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123477/#review79383
-----------------------------------------------------------


On Dub. 23, 2015, 1:01 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123477/
> -----------------------------------------------------------
> 
> (Updated Dub. 23, 2015, 1:01 odp.)
> 
> 
> Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> I'm not 100% sure how this should work and I couldn't find another framework doing the same, but Daniel Vrátil pointed me out that NetworkManagerQt should mention in KF5NetworkManagerQtConfig.cmake file that it requires NetworkManager as dependency. Given this, we also need to install FindNetworkManager.cmake into CMake modules so NetworkManager can be found by find_dependency() macro, or FindNetworkManager.cmake can go into extra-cmake-modules.
> 
> If this is how it should be done, then similar patch would be needed for ModemManagerQt.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c9e3274 
>   KF5NetworkManagerQtConfig.cmake.in cdabe8e 
> 
> Diff: https://git.reviewboard.kde.org/r/123477/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150423/6572bcd5/attachment-0001.html>