Review Request 123463: Use categorized logging in runtime component

[Martin Gräßlin]

> On April 22, 2015, 10:49 a.m., Martin Klapetek wrote:
> > src/runtime/logging_p.h, lines 21-23
> > <https://git.reviewboard.kde.org/r/123463/diff/1/?file=362353#file362353line21>
> >
> >     It's useful if this also has
> >     
> >     #include <QDebug>
> >     
> >     so that you don't have to include two headers in the code (QDebug and logging_p.h) to do qdebug output

that's a nice suggestion! Will add it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123463/#review79332
-----------------------------------------------------------


On April 22, 2015, 9:54 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123463/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 9:54 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Bugs: 346429
>     https://bugs.kde.org/show_bug.cgi?id=346429
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> BUG: 346429
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt e639fa5df96859f844476492235909756220ae5d 
>   src/runtime/component.cpp 3b5bdf99d0d26c032f2315bc4c1e64de5d321ee7 
>   src/runtime/globalshortcut.cpp 3fe7bd961d3cdb23857654b3abff630d5ec0c3ec 
>   src/runtime/globalshortcutsregistry.cpp 3e4d720e13f6cda8e1b2827c70fce22423474d75 
>   src/runtime/kglobalaccel_mac.cpp daaa24c3ec75cf6e78c923083b824ff331d6fe75 
>   src/runtime/kglobalaccel_win.cpp 7457e348502b6f9d8cbb71be37652cf10ecf6587 
>   src/runtime/kglobalaccel_x11.cpp abee5bcaa9795436833bc0b7fa5b259e7c3f86ac 
>   src/runtime/kglobalacceld.cpp 4e7cb9df1da37311d6f9e098f4d5b217cad54fd9 
>   src/runtime/logging.cpp PRE-CREATION 
>   src/runtime/logging_p.h PRE-CREATION 
>   src/runtime/main.cpp fdf4d62ea025e24b30a0f961fe16b87a1baf2bae 
> 
> Diff: https://git.reviewboard.kde.org/r/123463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/587fc2b9/attachment-0001.html>