Review Request 123417: Prevent plasmashell from crashing on wayland

Nerdopolis Turfwalker bluescreen_avenger at verizon.net
Wed Apr 22 01:18:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/
-----------------------------------------------------------

(Updated April 22, 2015, 1:18 a.m.)


Review request for KDE Frameworks.


Changes
-------

Simplify and fix the patch to protect X11 calls. Remove an uneeded test, don't set poller=0 many times.


Repository: kidletime


Description
-------

kidletime makes an unchecked X call, which is used by plasmashell.


Diffs (updated)
-----

  CMakeLists.txt 5335bd5db171721635517a82829f54cd1b3f6326 
  src/config-kidletime.h.cmake d3f0cfd78833d2b3acf90d0a068905676ceba586 
  src/kidletime.cpp f38ae467d78d899b70b602a932482a39402793fb 

Diff: https://git.reviewboard.kde.org/r/123417/diff/


Testing
-------

Ran plasmashell with QT_QPA_PLATFORM=wayland, and got no more crashes


Thanks,

Nerdopolis Turfwalker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150422/6e53755b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list