Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability
Jeremy Whiting
jpwhiting at kde.org
Sat Apr 18 20:58:38 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79181
-----------------------------------------------------------
This looks right to me, but it's Gregor's stuff (KMoreTools) so I'll let him weigh in. It may require the users of KMoreTools to update their code I believe.
- Jeremy Whiting
On April 18, 2015, 1:45 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123421/
> -----------------------------------------------------------
>
> (Updated April 18, 2015, 1:45 p.m.)
>
>
> Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Like it's done with the rest of the frameworks.
>
>
> Diffs
> -----
>
> data/CMakeLists.txt 32d39ab
> src/kmoretools/kmoretools.h 89e75b5
> src/kmoretools/kmoretools.cpp 27a0f74
>
> Diff: https://git.reviewboard.kde.org/r/123421/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150418/73235fb5/attachment.html>
More information about the Kde-frameworks-devel
mailing list