Review Request 123402: Moves away from KService

[Alex Richardson]

> On April 17, 2015, 5:52 p.m., Vishesh Handa wrote:
> > src/widgets/actions.cpp, line 34
> > <https://git.reviewboard.kde.org/r/123402/diff/1/?file=361770#file361770line34>
> >
> >     If you want you can also change this to the new for syntax.

But make sure that `personPluginList` is const, since otherwise it will make a copy


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123402/#review79138
-----------------------------------------------------------


On April 17, 2015, 4:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123402/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 4:45 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM and Martin Klapetek.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Using KPluginFactory for instantiating the plugins, maybe we could do a bit better there and just use QPluginLoader which is what we seem to need on most cases. See discussion on depending patch.
> 
> Tier 3 -> Tier 2
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 11e2aa6 
>   metainfo.yaml 9795646 
>   src/CMakeLists.txt 225cee5 
>   src/personpluginmanager.cpp 9dd3f6e 
>   src/widgets/actions.cpp ed7e02c 
>   src/widgets/persondetailsview.cpp 8a2ef5c 
> 
> Diff: https://git.reviewboard.kde.org/r/123402/diff/
> 
> 
> Testing
> -------
> 
> My KTP contact list still works, tests still pass and example applications still work as well.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150417/a4b02797/attachment-0001.html>