Review Request 123335: Fix native file dialogs from widgets QFileDialog
Jeremy Whiting
jpwhiting at kde.org
Thu Apr 16 22:44:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123335/#review79085
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On April 12, 2015, 3:20 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123335/
> -----------------------------------------------------------
>
> (Updated April 12, 2015, 3:20 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Lukáš Tinkl.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae fixed QML file dialogs but broke QtWidgets dialogs.
>
> QFileDialog static functions - dialog would open, but any user interaction is blocked (cannot select files or click on anything).
> QFileDialog *d = new QFileDialog(parent); d->open(); - dialog would not open at all
>
> The first issue occurs because exec() is called on already shown dialog. This is fixed by explicit hide() before calling exec() - kind of hacky :/
> The second issue is fixed by always calling show().
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 00e4a41
> autotests/kfiledialog_unittest.cpp 45a139a
> autotests/kfiledialogqml_unittest.cpp PRE-CREATION
> autotests/qml/filedialog_parentless.qml PRE-CREATION
> autotests/qml/filedialog_withparent.qml PRE-CREATION
> src/platformtheme/kdeplatformfiledialoghelper.cpp 92ab107
>
> Diff: https://git.reviewboard.kde.org/r/123335/diff/
>
>
> Testing
> -------
>
> QML dialogs:
> example from bug 334963 works fine
> file dialog from plasma desktop settings -> wallpapers works fine
>
> QtWidgets dialogs:
> static dialogs from qtbase/examples/widgets/dialogs/standarddialogs works fine
> QFileDialog *d = new QFileDialog(parent); d->open(); works fine
> test app: https://paste.kde.org/psddcng5n
>
> I'm running Qt 5.4.1.
>
> Are there any other types of dialogs that I forgot (and possibly broke)?
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150416/66341b56/attachment.html>
More information about the Kde-frameworks-devel
mailing list