Review Request 123360: Introduce LoopSound flag

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123360/#review78923
-----------------------------------------------------------



src/knotification.h (line 3)
<https://git.reviewboard.kde.org/r/123360/#comment53951>

    Update copyright date.



src/notifybyaudio.cpp (line 2)
<https://git.reviewboard.kde.org/r/123360/#comment53952>

    Update copyright date.



src/notifybyaudio.cpp (line 89)
<https://git.reviewboard.kde.org/r/123360/#comment53953>

    Should not this patch be followed by another patch that set LoopSound flag for Persistant notifications that *really* want sound to loop? This change can be considered a regression if such a persistant notification exists.


- Lamarque Souza


On April 14, 2015, 2:41 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123360/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 2:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 346148
>     https://bugs.kde.org/show_bug.cgi?id=346148
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Some notifications might want to loop the sound, eg. calling apps playing the ringing sound which is not wanted to play once. Currently the sound is looped for all persistent notifications, but that's not ideal as not all persistent notifications with sound want/need sound looping. This new LoopSound flag solves that.
> 
> 
> Diffs
> -----
> 
>   src/knotification.h 8efd92a 
>   src/notifybyaudio.cpp ee3ef1e 
> 
> Diff: https://git.reviewboard.kde.org/r/123360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150414/2c1deb56/attachment.html>