Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

[Jan Grulich]

> On Dub. 13, 2015, 7:13 dop., David Faure wrote:
> > examples/CMakeLists.txt, line 5
> > <https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5>
> >
> >     well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org
> 
> Jan Grulich wrote:
>     +1 for removing, it should be same for all frameworks, so there is no need to mention how to find the library.
> 
> Lamarque Souza wrote:
>     In quick search I could not find those information on api.kde.org. You have got a point that keeping those lines in CMakeLists.txt makes things easier for beginners. Let's keep them commented. This patch has +1 after changing examples/createconnection/CMakeLists.txt.

I think it's supposed to be here http://api.kde.org/frameworks-api/frameworks5-apidocs/networkmanager-qt/html/index.html on the left side, check other frameworks and you will see it's there. I guess we would need to update metainfo.yaml file to have it there. There is also a typo in git url (networkmanagerqt vs networkmanager-qt), but I don't know where to fix it.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123349/#review78882
-----------------------------------------------------------


On Dub. 12, 2015, 7:57 odp., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123349/
> -----------------------------------------------------------
> 
> (Updated Dub. 12, 2015, 7:57 odp.)
> 
> 
> Review request for KDE Frameworks and Jan Grulich.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> This is built as part of the framework, so it should not do
> find_package on itself, it won't work the first time.
> 
> I assume this was there in order to all build separately, so I left
> it commented out, but it's wrong to have that in.
> 
> Maybe with the last two commits, the examples can be built by default,
> like in the other frameworks, so that we ensure that they always do build?
> 
> 
> Diffs
> -----
> 
>   examples/CMakeLists.txt c2484b346b70596ddeb87778c7dd3881851441fb 
> 
> Diff: https://git.reviewboard.kde.org/r/123349/diff/
> 
> 
> Testing
> -------
> 
> rebuilt the examples from scratch, worked
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150413/e2263f13/attachment.html>