Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123329/#review78883
-----------------------------------------------------------

Ship it!



src/notifybytaskbar.cpp (line 45)
<https://git.reviewboard.kde.org/r/123329/#comment53937>

    That should perhaps be a qWarning?


- Martin Klapetek


On April 13, 2015, 11:10 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123329/
> -----------------------------------------------------------
> 
> (Updated April 13, 2015, 11:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Don't crash if notification has no widget and notification is set to notify by taskbar
> 
> 
> Diffs
> -----
> 
>   src/notifybytaskbar.cpp 72d01af 
> 
> Diff: https://git.reviewboard.kde.org/r/123329/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150413/52c9edf3/attachment-0001.html>