Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123349/#review78875
-----------------------------------------------------------



examples/CMakeLists.txt (line 5)
<https://git.reviewboard.kde.org/r/123349/#comment53935>

    You are right, it was there to allow to enable examples separately. You can remove those lines instead of commenting them.
    
    You need to do this same change in the other example (examples/createconnection/CMakeLists.txt) or it will fail to build.


- Lamarque Souza


On April 12, 2015, 7:57 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123349/
> -----------------------------------------------------------
> 
> (Updated April 12, 2015, 7:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Jan Grulich.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> This is built as part of the framework, so it should not do
> find_package on itself, it won't work the first time.
> 
> I assume this was there in order to all build separately, so I left
> it commented out, but it's wrong to have that in.
> 
> Maybe with the last two commits, the examples can be built by default,
> like in the other frameworks, so that we ensure that they always do build?
> 
> 
> Diffs
> -----
> 
>   examples/CMakeLists.txt c2484b346b70596ddeb87778c7dd3881851441fb 
> 
> Diff: https://git.reviewboard.kde.org/r/123349/diff/
> 
> 
> Testing
> -------
> 
> rebuilt the examples from scratch, worked
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150412/f8c60ad4/attachment.html>