Review Request 123335: Fix native file dialogs from widgets QFileDialog

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123335/
-----------------------------------------------------------

(Updated April 12, 2015, 9:20 a.m.)


Review request for KDE Frameworks, David Faure and Lukáš Tinkl.


Changes
-------

Add unittests for show(), open() and QML dialogs, each with and without parent.

I am not sure how to test non-interactive bug with exec() though


Repository: frameworkintegration


Description
-------

9814e4b773b2b34afafa0c5d242594bbb4f9a6ae fixed QML file dialogs but broke QtWidgets dialogs.

QFileDialog static functions - dialog would open, but any user interaction is blocked (cannot select files or click on anything).
QFileDialog *d = new QFileDialog(parent); d->open(); - dialog would not open at all

The first issue occurs because exec() is called on already shown dialog. This is fixed by explicit hide() before calling exec() - kind of hacky :/
The second issue is fixed by always calling show().


Diffs (updated)
-----

  autotests/CMakeLists.txt 00e4a41 
  autotests/kfiledialog_unittest.cpp 45a139a 
  autotests/kfiledialogqml_unittest.cpp PRE-CREATION 
  autotests/qml/filedialog_parentless.qml PRE-CREATION 
  autotests/qml/filedialog_withparent.qml PRE-CREATION 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 92ab107 

Diff: https://git.reviewboard.kde.org/r/123335/diff/


Testing
-------

QML dialogs: 
example from bug 334963 works fine
file dialog from plasma desktop settings -> wallpapers works fine

QtWidgets dialogs:
static dialogs from qtbase/examples/widgets/dialogs/standarddialogs works fine
QFileDialog *d = new QFileDialog(parent); d->open(); works fine
test app: https://paste.kde.org/psddcng5n

I'm running Qt 5.4.1.

Are there any other types of dialogs that I forgot (and possibly broke)?


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150412/e0b45d0e/attachment.html>