Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

[Gregor Mi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
-----------------------------------------------------------

(Updated April 10, 2015, 10:53 a.m.)


Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.


Changes
-------

- remove loadShortcutFromGlobalSettings()
- introduce KGlobalAccel::shortcut(const QString& componentName, const QString& actionId) including unit test
- all unit tests work


Repository: kglobalaccel


Description
-------

In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut() (which is const).

See discussion in https://git.reviewboard.kde.org/r/122249/ ("libksysguard: add Kill Window to End Process button and show correct keyboard shortcut").


Diffs (updated)
-----

  autotests/kglobalshortcuttest.cpp 3b661bbb612807a3bbbe34835d4ae712c2ec74da 
  src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
  src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 
  src/kglobalaccel_p.h eca7c52378ad60d0d5806561214b9788dd46a11e 
  autotests/kglobalshortcuttest.h b1122a8f5ca2f3f7afbe78f8edba87325426c1a6 

Diff: https://git.reviewboard.kde.org/r/122981/diff/


Testing
-------


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150410/973cb0fb/attachment.html>