Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123178/
-----------------------------------------------------------

(Updated April 9, 2015, 7:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 7a3735e2bfcb506e820961199c37f5876a1de7fd by David Gil to branch master.


Repository: kcompletion


Description
-------

The deleted condition checks whether completionMode is different
to KCompletion::CompletionNone. This condition is inside another condition
that checks the same. Therefore it's useless.

Besides, at the beginning of the method there are multiple else if conditions
that aren't actually related (they are independent and each one ends
with a "return"). Therefore, I have cleaned up the elses and left the ifs. I
think that way the method is cleaner and more readable (as readable as it
can be, given the length of it and the number of conditions).


Diffs
-----

  src/klineedit.cpp 7c2d0f9 

Diff: https://git.reviewboard.kde.org/r/123178/diff/


Testing
-------

Tests pass


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150409/68da1e83/attachment.html>