Review Request 123268: Fix extraction of some messages
Lasse Liehu
lasse.liehu at gmail.com
Sun Apr 5 19:06:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123268/
-----------------------------------------------------------
Review request for KDE Frameworks and Christoph Feck.
Repository: kwidgetsaddons
Description
-------
Wrapping QCoreApplication::translate calls into a new function broke extraction.
Also ported remaining I18N_NOOP2 uses to Qt's i18n system.
Added semicolons to the end of QT_TRANSLATE_NOOP3 uses because without them only the first //: comment would be extracted.
Diffs
-----
src/fonthelpers.cpp 1a1a2f4
src/kdatetimeedit.cpp 63686ad
src/kmessagebox.cpp 7c2a577
src/kmimetypechooser.cpp 51c4044
Diff: https://git.reviewboard.kde.org/r/123268/diff/
Testing
-------
Compiled and ran unit tests. Also ran lrelease locally and checked that messages and their //: comments were extracted properly.
Thanks,
Lasse Liehu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150405/9f9c52cb/attachment.html>
More information about the Kde-frameworks-devel
mailing list