Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.
David Faure
faure at kde.org
Sat Apr 4 11:45:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122232/
-----------------------------------------------------------
(Updated April 4, 2015, 11:45 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Matthew Dawson.
Changes
-------
Submitted with commit ee599bfa17f7e56b0db1a4afbbfe929ec90f2c9d by David Faure to branch master.
Repository: kconfig
Description
-------
kconfig_in_global_object.cpp comes from kdelibs4support
(after porting to Q_GLOBAL_STATIC)
ksharedconfig_in_global_object.cpp is now in kdelibs4 too
(where it works) and reproduces Albert's KgDifficulty testcase.
Diffs
-----
autotests/CMakeLists.txt b91f754b705fc87bb8b729bea72fbb5f7d427ace
autotests/kconfig_in_global_object.cpp PRE-CREATION
autotests/ksharedconfig_in_global_object.cpp PRE-CREATION
src/core/kconfig.cpp 1da816faea5548d2f529755d6538a142a2193720
src/core/ksharedconfig.h d0791e461804d421010bc5f82873371a4d3bc992
Diff: https://git.reviewboard.kde.org/r/122232/diff/
Testing
-------
Both tests pass and the QCoreApplication::arguments warning (because called after qApp is destroyed) is gone.
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150404/dec3949b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list