Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123229/#review78476
-----------------------------------------------------------



src/widgets/kdynamicjobtracker.cpp (line 84)
<https://git.reviewboard.kde.org/r/123229/#comment53683>

    Why not skip the dbus call altogether, if this isn't a QApp?
    
    I.e. move that if() a few lines above


- David Faure


On April 2, 2015, 4:09 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123229/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Prevents the UiDelegate and UiTracker to get initialized, because they'll try to create windows and dialogs when some things happen and these will immediately end in a crash.
> 
> 
> Diffs
> -----
> 
>   src/widgets/jobuidelegate.cpp 7df289f 
>   src/widgets/kdynamicjobtracker.cpp 9bc4a4e 
> 
> Diff: https://git.reviewboard.kde.org/r/123229/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests, my unit test doesn't crash anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150404/a4d5f7af/attachment.html>