Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings
Gregor Mi
codestruct at posteo.org
Sat Apr 4 09:14:42 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78472
-----------------------------------------------------------
src/kglobalaccel.h (line 372)
<https://git.reviewboard.kde.org/r/122981/#comment53681>
NOTE that this causes compile error in libKF5XmlGui
/home/gregor/dev/kf5/usr/lib64/libKF5XmlGui.so.5.8.0: undefined reference to `KGlobalAccel::globalShortcutChanged(QAction*, QKeySequence const&)'
collect2: error: ld returned 1 exit status
- Gregor Mi
On April 3, 2015, 5:50 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 5:50 p.m.)
>
>
> Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut() (which is const).
>
> See discussion in https://git.reviewboard.kde.org/r/122249/ ("libksysguard: add Kill Window to End Process button and show correct keyboard shortcut").
>
>
> Diffs
> -----
>
> autotests/kglobalshortcuttest.h b1122a8f5ca2f3f7afbe78f8edba87325426c1a6
> autotests/kglobalshortcuttest.cpp 3b661bbb612807a3bbbe34835d4ae712c2ec74da
> src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16
> src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
> src/kglobalaccel_p.h eca7c52378ad60d0d5806561214b9788dd46a11e
>
> Diff: https://git.reviewboard.kde.org/r/122981/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150404/20fa7f5e/attachment.html>
More information about the Kde-frameworks-devel
mailing list