Review Request 120648: Encode the URIs which end up in DTD files
Andrius da Costa Ribas
andriusmao at gmail.com
Fri Apr 3 15:58:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
-----------------------------------------------------------
cmake/uriencode.cmake (line 15)
<https://git.reviewboard.kde.org/r/120648/#comment53670>
I've tried changing this to:
execute_process(COMMAND perl -MURI::Escape -e "print uri_escape_utf8(\"${escaped_uri}\", \"^A-Za-z0-9\\-\\._~\\/\\\\:\");"
(...)
it works here, but I'm not sure if it'd be the proper fix.
- Andrius da Costa Ribas
On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
>
> (Updated Fev. 28, 2015, 10:02 p.m.)
>
>
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
>
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
>
>
> Diffs
> -----
>
> cmake/uriencode.cmake PRE-CREATION
> src/CMakeLists.txt 341ecf4
>
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
>
>
> Testing
> -------
>
> It compiles, but I can't properly test Mac and Windows scenarios
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150403/d30854ae/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list