Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

Gregor Mi codestruct at posteo.org
Thu Apr 2 14:56:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
-----------------------------------------------------------

(Updated April 2, 2015, 2:56 p.m.)


Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.


Changes
-------

update description


Repository: kglobalaccel


Description (updated)
-------

In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut() (which is const).

See discussion in https://git.reviewboard.kde.org/r/122249/ ("libksysguard: add Kill Window to End Process button and show correct keyboard shortcut").


Diffs
-----

  autotests/kglobalshortcuttest.h 2a7b40d34875e16345a659fb9764e4f536ad79c6 
  autotests/kglobalshortcuttest.cpp 169bf92ffbff985cd4381e771c2fcecaff77156b 
  src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
  src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 

Diff: https://git.reviewboard.kde.org/r/122981/diff/


Testing
-------


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150402/cbbc742a/attachment.html>


More information about the Kde-frameworks-devel mailing list