Review Request 123216: Save some memory in kglobalaccel runtime

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123216/#review78389
-----------------------------------------------------------


hmm just wondering: why does it need to be a QApplication? Maybe a QGuiApplication would be sufficient?

- Martin Gräßlin


On April 1, 2015, 7:23 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123216/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 7:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> KGlobalAccel needs to be a full QApplication as it needs an X connection to intercept widgets, however it doesn't actually show any widgets.
> 
> By setting desktopSettingsAware to false we can avoid loading some settings which ends up saving ~2Mb of RAM.
> 
> 
> Diffs
> -----
> 
>   src/runtime/main.cpp fdf4d62 
> 
> Diff: https://git.reviewboard.kde.org/r/123216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150402/0272458d/attachment.html>