Review Request 123210: Don't display black square if icon is not set
Martin Gräßlin
mgraesslin at kde.org
Wed Apr 1 14:04:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123210/#review78338
-----------------------------------------------------------
Ship it!
src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp (line 109)
<https://git.reviewboard.kde.org/r/123210/#comment53630>
nitpick: Q_NULLPTR
src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp (line 111)
<https://git.reviewboard.kde.org/r/123210/#comment53631>
nitpick: whitespace
- Martin Gräßlin
On April 1, 2015, 4:01 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123210/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 4:01 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Don't display black square if icon is not set
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 70f2e73
>
> Diff: https://git.reviewboard.kde.org/r/123210/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150401/7f45617d/attachment.html>
More information about the Kde-frameworks-devel
mailing list