Review Request 119767: Add Hamlet and Haskell quasiquotation
Bastian Holst
bastianholst at gmx.de
Tue Sep 30 19:25:47 UTC 2014
> On Aug. 15, 2014, 12:22 nachm., Dominik Haumann wrote:
> > src/syntax/data/haskell.xml, line 363
> > <https://git.reviewboard.kde.org/r/119767/diff/2/?file=305500#file305500line363>
> >
> > This question persists:
> >
> > The rule
> > <DetectChar attribute="Normal" context="List or QuasiQuote" char="["/>
> > from line 357 is included in this context.
> >
> > Matching '[' will switch to "List or QuasiQuote".
> > Since the rule above is in this context again, finding '[' will again switch into this context, such that the contexts add up.
> >
> > That is what I meant before when asking "Do you ever #pop back to the context "code"?" :-)
> >
> > Would it also be possible to use fallthrough and fallthroughContext like this:
> > <context attribute="Normal" lineEndContext="#stay" name="List or QuasiQuote" fallthrough="true" fallthroughContext="#pop">
> > and then remove the line 360?
> > <IncludeRules context="code" />
>
> Dominik Haumann wrote:
> Hi Bastian, do you have any updates here? :)
I think I fixed this. I pop back to the context "List or QuasiQuote" on a "|" and pop then back to the context "code" on "]".
However, I think another problem remains: ListComprehension. This may look like that: "[xs | Just x <- ys]"
I wonder how the Haskell parser does this, by reading the whole list/comprehension/quasiquote and backtracking?
- Bastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119767/#review64598
-----------------------------------------------------------
On Aug. 14, 2014, 8:39 nachm., Bastian Holst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119767/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 8:39 nachm.)
>
>
> Review request for Kate, KDE Frameworks and Christoph Cullmann.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> This request request mostly contains syntax highlighting for Hamlet
> files. Hamlet is a Haskell based Template language for creating
> HTML documents. As Hamlet can be embedded into an ordinary Haskell
> file with quasi quotation, this also implements QuasiQuotation support
> for Haskell files.
>
>
> Diffs
> -----
>
> src/syntax/data/hamlet.xml PRE-CREATION
> src/syntax/data/haskell.xml 104e43ddafb2e7ca5ccc84fcf8344267e3148e05
>
> Diff: https://git.reviewboard.kde.org/r/119767/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian Holst
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140930/40ce416c/attachment.html>
More information about the Kde-frameworks-devel
mailing list