Review Request 120422: Fix build with Qt 5.4 - Implement SystemTrayMenuItem::setIconSize

Àlex Fiestas afiestas at kde.org
Mon Sep 29 23:07:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120422/#review67653
-----------------------------------------------------------


I could accept the patch, problem is that later on we might forget to fix this properly :/

Will check tomorrow what this new virtual is supposed to do and see what we can do about it.

- Àlex Fiestas


On set. 29, 2014, 1:32 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120422/
> -----------------------------------------------------------
> 
> (Updated set. 29, 2014, 1:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Otherwise it's a pure virtual class. I'm unsure what should be done in this case though. If somebody knows I'll be happy to fix it.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6ceaa43 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 3ada7d2 
> 
> Diff: https://git.reviewboard.kde.org/r/120422/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140929/a1aec28c/attachment.html>


More information about the Kde-frameworks-devel mailing list