Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

[Hrvoje Senjan]

> On Sept. 29, 2014, 3:36 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so?
> 
> Helio Castro wrote:
>     Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file, there's include directories for older polkit-qt, but was clearly missing on polkit-qt5-1.

but i wonder 2 things, first why is this needed, second, why not fix polkit-qt-1 then?


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421/#review67622
-----------------------------------------------------------


On Sept. 29, 2014, 2:59 p.m., Helio Castro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120421/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 2:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> - Update cmake files to match official polkit package, then enabling to use different include direcories
> 
> 
> Diffs
> -----
> 
>   src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 
> 
> Diff: https://git.reviewboard.kde.org/r/120421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Helio Castro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140929/94d2f516/attachment.html>