Review Request 120408: Port textcreator thumbnailer
Christoph Feck
christoph at maxiom.de
Sun Sep 28 22:47:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120408/#review67599
-----------------------------------------------------------
Ship it!
Ship It!
- Christoph Feck
On Sept. 28, 2014, 10:41 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120408/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2014, 10:41 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Quick port. I left the kencodingprober code for now. Maybe we should just drop it? Or fix kencodingprober.
> thumbcreator needs to be a QGuiApplication because we use pixmaps.
>
>
> Diffs
> -----
>
> thumbnail/thumbnail.cpp 3a38dc9
> thumbnail/textcreator.cpp d3f633c
> thumbnail/CMakeLists.txt aec8b8e
>
> Diff: https://git.reviewboard.kde.org/r/120408/diff/
>
>
> Testing
> -------
>
> Text thumbnails work.
> Utf8 files show with the correct encoding.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140928/628ee6c0/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list