Review Request 120408: Port textcreator thumbnailer

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120408/#review67586
-----------------------------------------------------------


I suggest to keep the KEncodingProber code for now, as the change is unrelated to KF5 porting.


thumbnail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120408/#comment47109>

    Is there a space missing in front, or does RB fool me?



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/120408/#comment47110>

    While you are at it, remove the space after "("


- Christoph Feck


On Sept. 28, 2014, 5:05 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120408/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 5:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Quick port. I left the kencodingprober code for now. Maybe we should just drop it? Or fix kencodingprober.
> thumbcreator needs to be a QGuiApplication because we use pixmaps.
> 
> 
> Diffs
> -----
> 
>   thumbnail/CMakeLists.txt aec8b8e 
>   thumbnail/textcreator.cpp d3f633c 
>   thumbnail/thumbnail.cpp 3a38dc9 
> 
> Diff: https://git.reviewboard.kde.org/r/120408/diff/
> 
> 
> Testing
> -------
> 
> Text thumbnails work.
> Utf8 files show with the correct encoding.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140928/8dcd5e0a/attachment-0001.html>