Review Request 120388: Do not sync if wallet file does not exist

Arjun AK arjunak234 at gmail.com
Sat Sep 27 11:59:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review67522
-----------------------------------------------------------



src/runtime/kwalletd/backend/kwalletbackend.cc
<https://git.reviewboard.kde.org/r/120388/#comment47078>

    Is the return value correct?


- Arjun AK


On Sept. 27, 2014, 5:29 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 5:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the wallet, but this data will be lost once the wallet is closed since the salt has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140927/2eb48673/attachment.html>


More information about the Kde-frameworks-devel mailing list