Review Request 120382: Port comicbook thumbnailer to KF5

Maarten De Meyer de.meyer.maarten at gmail.com
Sat Sep 27 10:12:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120382/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 10:12 a.m.)


Review request for KDE Frameworks.


Repository: kio-extras


Description
-------

Mostly standard porting stuff.
I'll change the qdebug calls to qCDebug later. I'm planning to create a global thumbnail logging component.


Diffs (updated)
-----

  CMakeLists.txt b582741 
  thumbnail/CMakeLists.txt cd1263a 
  thumbnail/comiccreator.cpp 39df58a 

Diff: https://git.reviewboard.kde.org/r/120382/diff/


Testing
-------

Works fine on my small collection (only cbr files)


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140927/f3c8642f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list