Review Request 120380: Fix CMakeLists.txt to pass KDESU_USE_SUDO_DEFAULT to the compilation so it is used by suprocess.cpp

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120380/#review67493
-----------------------------------------------------------


It looks weird to pass C++ code directly from a cmake argument.

Maybe you can make it a normal cmake option() and use configure_file() to generate a kdesu_config.h file?

- Aleix Pol Gonzalez


On Sept. 26, 2014, 3:35 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120380/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 3:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> output note describing -DKDESU_USE_SUDO_DEFAULT=true
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f51997b64d010e434e5930e43332cbf5d6b8eec7 
>   src/CMakeLists.txt e57c4196e6f48596c57060b7b4e7316a471beee3 
> 
> Diff: https://git.reviewboard.kde.org/r/120380/diff/
> 
> 
> Testing
> -------
> 
> compiled, installed and ran kdesu, takes my user password instead of root
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140926/c2103d7a/attachment.html>